forked from dxw/php-missing
-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unparse url function #2
Open
MarikaBBB
wants to merge
27
commits into
main
Choose a base branch
from
unparseUrlFunction
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR is in relation to Issue dxw#19 and implements
unparse_url()
function to complement PHP's nativeparse_url()
. Whileparse_url()
parses a URL into its components, PHP does not provide a built-in way to reconstruct the URL, which is why this function is needed.I created PHPUnit Test class
Urls_test
and implemented theunparse_urls
function in theUrls
class.Reference:
I looked not PHP
parse_url
Documentation: PhP: parse_url - ManualStackoverflow example solution already suggested in the #issue19 https://stackoverflow.com/questions/4354904/php-parse-url-reverse-parsed-url/31691249#31691249
How to test
Before testing please check and update dependencies by running command line
composer install
Then, run the command
./vendor/bin/phpunit tests/urls_test.php
for testing.